(importer) Minor performance improvements for FileNameProducer #8353
+33
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paw-hub
force-pushed
the
filename-producer-perf
branch
from
d9ee307 to
35c3d6b
Compare
paw-hub
changed the title
paw-hub
force-pushed
the
filename-producer-perf
branch
from
35c3d6b to
7bbe8d8
Compare
paw-hub
changed the title
paw-hub
changed the title
paw-hub
force-pushed
the
filename-producer-perf
branch
4 times, most recently
from
27b67ff to
054a011
Compare
|
oops meant to rebase on master |
ganthern
approved these changes
Jan 23, 2025
This should make FileNameProducer slightly more performant: - Use Path::file_stem to get the filename without needing to clone path. - Use format macro for building strings to reduce allocations.
paw-hub
force-pushed
the
filename-producer-perf
branch
from
054a011 to
51b4669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make FileNameProducer slightly more performant: