Hello, The change here has the exact same functionality while encoding and don't feel like is causing this issue.

import Url from "url-parse";
const url = "https://example.com/path?test=param'WithQuote&Body=It's+amazing";

console.log(new Url(url));
Output:
URL {
  href: 'https://example.com/path?test=param%27WithQuote&Body=It%27s+amazing',
  origin: 'https://example.com',
  protocol: 'https:',
  username: '',
  password: '',
  host: 'example.com',
  hostname: 'example.com',
  port: '',
  pathname: '/path',
  search: '?test=param%27WithQuote&Body=It%27s+amazing',
  searchParams: URLSearchParams { 'test' => "param'WithQuote", 'Body' => "It's amazing" },
  hash: ''
}

In built URL

const url = "https://example.com/path?test=param'WithQuote&Body=It's+amazing";
console.log(new URL(url));
URL {
  href: 'https://example.com/path?test=param%27WithQuote&Body=It%27s+amazing',
  origin: 'https://example.com',
  protocol: 'https:',
  username: '',
  password: '',
  host: 'example.com',
  hostname: 'example.com',
  port: '',
  pathname: '/path',
  search: '?test=param%27WithQuote&Body=It%27s+amazing',
  searchParams: URLSearchParams { 'test' => "param'WithQuote", 'Body' => "It's amazing" },
  hash: ''
}

Can you elaborate further what is the use case here which is causing problem for you?

@manisha1997 I'm a bit confused about the role of url-parse in your reply 🤔. I'd appreciate any clarification.

Use Case:

I’m trying to use the validateRequest() function from the twilio-node package to validate a Twilio signature generated by a Twilio server.

The Scenario That Fails:

1. I set up a status callback to handle when the caller hangs up: https://api.example.com/status-callback

2. This status callback receives aPOST request: POST https://api.example.com/status-callback

3. The status callback returns a 307 - Temporary Redirect with the header Location: https://api.example.com/hang-up

4. As per the spec, the 307 status code should preserve the original HTTP method (see MDN documentation) but that's a different issue. In this case, Twilio sends a GET request to https://api.example.com/hang-up, with the body parameters converted into a query string.

5. When I use validateRequest() to validate the x-twilio-signature header, it fails if any of the parameters in the query string contain a single quote ('), such as FromState or ToState (FromState=Trezzo Sull'Adda)

What Seems to Be Happening:

It looks like the single quote (') is escaped when using new URL(), but the Twilio server seems to generate the signature with the unescaped quote, causing the validation to fail.

We found the issue and working on a fix

@manisha1997 You can take also a look at what I did in 😃 #1061

sure, I am taking a look at that too