fix(webhooks): validate Twilio signatures with escaped and unescaped query string values fixes #1059 #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leon19
force-pushed
the
bugfix/request-validation-with-query-string-values-containing-single-quotes
branch
5 times, most recently
from
369a399 to
66e4862
Compare
…query string values fixes twilio#1059
leon19
force-pushed
the
bugfix/request-validation-with-query-string-values-containing-single-quotes
branch
from
66e4862 to
4c908e6
Compare
tiwarishubham635
requested changes
Jan 16, 2025
leon19
force-pushed
the
bugfix/request-validation-with-query-string-values-containing-single-quotes
branch
from
cb82ff9 to
cd6a943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1059
Update the
validateRequest()function to fallback to a query string parser that does not escape single quotes if the request validation fails.Why?
Query string values that contain single quotes (
') are escaped when usingnew URL(), but the Twilio server seems to generate the signature with the unescaped single quote value, causing the validation to fail in the scenario described in #1059Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.