Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings post move to scala 2.11 #130

Merged
merged 3 commits into from
Jan 26, 2015
Merged

Remove warnings post move to scala 2.11 #130

merged 3 commits into from
Jan 26, 2015

Conversation

AnishShah
Copy link
Contributor

No description provided.

@AnishShah
Copy link
Contributor Author

Working on SynchronizedBuffer warning. Should I use java.util.concurrent.ConcurrentLinkedQueue as the Deprecation warning says ?

@szymonm
Copy link
Contributor

szymonm commented Jan 24, 2015

I think so.

On Sat Jan 24 2015 at 14:06:19 Anish Shah [email protected] wrote:

Working on SynchronizedBuffer warning. Should I use
java.util.concurrent.ConcurrentLinkedQueue as the Deprecation warning
says ?


Reply to this email directly or view it on GitHub
#130 (comment).

@AnishShah
Copy link
Contributor Author

This removes all the warnings, except

[warn] There may be incompatibilities among your library dependencies.
[warn] Here are some of the libraries that were evicted:
[warn]  * com.google.guava:guava:13.0.1 -> 16.0.1
[warn] Run 'evicted' to see detailed eviction warnings

@pankajgupta
Copy link
Contributor

Filed separate issue #132 for the library eviction warnings. Perhaps @caniszczyk or @travisbrown have seen that elsewhere as well?


/**
* A simple implementation of a DirectedGraph
*/
case class TestGraph(nodes: Node*) extends DirectedGraph {
val nodeTable = new mutable.HashMap[Int, Node]
val nodeTable = new HashMap[Int, Node]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is considered best practice to explicitly specify mutable.HashMap and import only scala.collection.mutable (see http://docs.scala-lang.org/overviews/collections/overview.html starting from "A useful convention is...")

@pankajgupta
Copy link
Contributor

LGTM otherwise

pankajgupta added a commit that referenced this pull request Jan 26, 2015
Remove warnings post move to scala 2.11
@pankajgupta pankajgupta merged commit 1603350 into twitter:master Jan 26, 2015
@AnishShah AnishShah deleted the issue128 branch January 26, 2015 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants