-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove warnings post move to scala 2.11 #130
Conversation
Working on |
I think so. On Sat Jan 24 2015 at 14:06:19 Anish Shah [email protected] wrote:
|
This removes all the warnings, except
|
Filed separate issue #132 for the library eviction warnings. Perhaps @caniszczyk or @travisbrown have seen that elsewhere as well? |
|
||
/** | ||
* A simple implementation of a DirectedGraph | ||
*/ | ||
case class TestGraph(nodes: Node*) extends DirectedGraph { | ||
val nodeTable = new mutable.HashMap[Int, Node] | ||
val nodeTable = new HashMap[Int, Node] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is considered best practice to explicitly specify mutable.HashMap and import only scala.collection.mutable (see http://docs.scala-lang.org/overviews/collections/overview.html starting from "A useful convention is...")
LGTM otherwise |
Remove warnings post move to scala 2.11
No description provided.