Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't try to advance time by Zero #4238

Open
wants to merge 1 commit into
base: series/3.6.x
Choose a base branch
from

Conversation

Jasper-M
Copy link
Contributor

Correct me if that's impossible, but I suspect this caused some requirement failed errors to randomly occur in our CI.

@djspiewak
Copy link
Member

Huh. This situation really should be impossible, simply because tick() should be vacuuming up everything which is available at the current time epoch, so the next should always be strictly greater than zero. If you're seeing cases where that isn't true, then something else is definitely broken.

@Jasper-M
Copy link
Contributor Author

Huh, that does seem impossible indeed 🫤
Unfortunately as it only seems to occur sometimes, I didn't yet manage to get more information out of it than this stacktrace

java.lang.IllegalArgumentException: requirement failed
  at scala.Predef$.require(Predef.scala:324)
  at executeEmbed @ com.example.MySpec$$anon$1.<init>(MySpec.scala:46)
  at executeEmbed @ com.example.MySpec$$anon$1.<init>(MySpec.scala:46)

where 46 is the line where I call unsafeRunSync().

I have to admit that we are calling an actual database in this test in combination with TestControl, which I've suspected from the beginning is causing this issue. But still weird that it doesn't fail consistently in that case. And I don't see which other require call it can be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants