support of user-created components, using pathlib, and renaming part filename #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tingjhenjiang
commented
May 5, 2024
tingjhenjiang
commented
- now users can retrieve components they created on their own.
- using pathlib in path generation and file writing for more robustness in different env.
- if there are slashes or backslashes in the part name/component name, writing files would cause errors. Now correct it.
added 5 commits
May 5, 2024 21:28
… pathlib in path generation and file writing for more robustness in different env.
…file processing; 3. rename part file name where slashes and backslashes exists.
…file processing; 3. rename slashes and backslashes in part, symbol, footprint file name.
|
@tingjhenjiang Thanks a lot for your contributions. Before merging your code, could you :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.