Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added relative path option for 3D-Files #44

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

swissbyte
Copy link

Hi There

I have added a new flag for the commandline.
It enables you to store the 3D-File relative to the project folder.

In fact it opens all kicad_mod files and changes the absolute path to a relative one.
For example:

(model "${KIPRJMOD}/test.3dshapes/LED0603-R-RD_BLUE.wrl"

${KIPRJMOD} is the path of the project.

Would be nice, if you accept the pull request :)

@uPesy uPesy changed the base branch from master to dev June 3, 2022 11:06
@uPesy
Copy link
Owner

uPesy commented Jun 7, 2022

Hi @swissbyte 🙂
Thanks for your PR !
What is your usecase of using relative path option for 3D-Files instead of absolute ? For a project specific library ?

@swissbyte
Copy link
Author

Yes, for a project specific library

@uPesy
Copy link
Owner

uPesy commented Jun 8, 2022

Ok i see, good idea !
For the MPN field, it's already included in field 1

property_template.format(
key="Value",
value=self.name,
id_=1,
pos_y=self.y_low - field_offset_y,
font_size=KiExportConfigV6.PROPERTY_FONT_SIZE.value,
style="",
hide="",
),

@github-actions
Copy link

github-actions bot commented Jul 9, 2022

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Stale label Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants