Skip to content

Commit

Permalink
chore: change app ID for android release due to identify theft (#1104)
Browse files Browse the repository at this point in the history
  • Loading branch information
Feichtmeier authored Dec 27, 2024
1 parent ac2f927 commit cc6d113
Show file tree
Hide file tree
Showing 8 changed files with 31 additions and 24 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@
*.swp
.DS_Store
.atom/
.build/
.buildlog/
.history
.svn/
.swiftpm/
migrate_working_dir/

# IntelliJ related
Expand Down
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ if (keystorePropertiesFile.exists()) {


android {
namespace = "org.feichtmeier.musicpod"
namespace = "org.feichtmeier.apps.musicpod"
compileSdk = flutter.compileSdkVersion
ndkVersion "27.0.12077973"

Expand All @@ -27,7 +27,7 @@ android {
}

defaultConfig {
applicationId = "org.feichtmeier.musicpod"
applicationId = "org.feichtmeier.apps.musicpod"
minSdk = 23
targetSdk = flutter.targetSdkVersion
versionCode = flutter.versionCode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.feichtmeier.musicpod
package org.feichtmeier.apps.musicpod

import io.flutter.embedding.android.FlutterActivity

Expand Down
3 changes: 2 additions & 1 deletion lib/app/view/mobile_navigation_bar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ class MobileNavigationBar extends StatelessWidget with WatchItMixin {
return SizedBox(
height: navigationBarHeight,
child: Padding(
padding: const EdgeInsets.only(top: kMediumSpace),
padding:
const EdgeInsets.only(bottom: kLargestSpace, top: kSmallestSpace),
child: Row(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: [
Expand Down
2 changes: 1 addition & 1 deletion lib/common/view/theme.dart
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ double get audioCardDimension =>

double get bottomPlayerDefaultHeight => isMobilePlatform ? 76.0 : 90.0;

double get navigationBarHeight => bottomPlayerDefaultHeight - 25;
double get navigationBarHeight => bottomPlayerDefaultHeight;

double? get bottomPlayerPageGap => isMobilePlatform
? bottomPlayerDefaultHeight + navigationBarHeight + kLargestSpace
Expand Down
4 changes: 2 additions & 2 deletions lib/constants.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
const kAppName = 'musicpod';
const kAppTitle = 'MusicPod';
const kAppId = 'org.feichtmeier.Musicpod';
const kAndroidAppId = 'org.feichtmeier.musicpod';
const kAndroidAppId = 'org.feichtmeier.apps.musicpod';
const kDiscordApplicationId = '1235321910221602837';
const kLinuxDBusName = 'org.mpris.MediaPlayer2.musicpod';
const kAndroidChannelId = 'org.feichtmeier.musicpod.channel.audio';
const kAndroidChannelId = 'org.feichtmeier.apps.musicpod.channel.audio';
const kRepoUrl = 'http://github.com/ubuntu-flutter-community/musicpod';
const kSponsorLink = 'https://github.com/sponsors/Feichtmeier';
const kGitHubShortLink = 'ubuntu-flutter-community/musicpod';
Expand Down
4 changes: 4 additions & 0 deletions macos/Runner/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,8 @@ class AppDelegate: FlutterAppDelegate {
override func applicationShouldTerminateAfterLastWindowClosed(_ sender: NSApplication) -> Bool {
return true
}

override func applicationSupportsSecureRestorableState(_ app: NSApplication) -> Bool {
return true
}
}
34 changes: 17 additions & 17 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -363,10 +363,10 @@ packages:
dependency: transitive
description:
name: dart_style
sha256: "64b717484993e85315d0c04081b6fca9ef8bac8c2cb794b2e15810250b335913"
sha256: "27eb0ae77836989a3bc541ce55595e8ceee0992807f14511552a898ddd0d88ac"
url: "https://pub.dev"
source: hosted
version: "3.0.0"
version: "3.0.1"
dbus:
dependency: transitive
description:
Expand Down Expand Up @@ -451,10 +451,10 @@ packages:
dependency: "direct main"
description:
name: file_picker
sha256: c2376a6aae82358a9f9ccdd7d1f4006d08faa39a2767cce01031d9f593a8bd3b
sha256: c904b4ab56d53385563c7c39d8e9fa9af086f91495dfc48717ad84a42c3cf204
url: "https://pub.dev"
source: hosted
version: "8.1.6"
version: "8.1.7"
file_selector:
dependency: "direct main"
description:
Expand Down Expand Up @@ -823,10 +823,10 @@ packages:
dependency: transitive
description:
name: lints
sha256: "4a16b3f03741e1252fda5de3ce712666d010ba2122f8e912c94f9f7b90e1a4c3"
sha256: c35bb79562d980e9a453fc715854e1ed39e24e7d0297a880ef54e17f9874a9d7
url: "https://pub.dev"
source: hosted
version: "5.1.0"
version: "5.1.1"
list_counter:
dependency: transitive
description:
Expand Down Expand Up @@ -912,7 +912,7 @@ packages:
description:
path: media_kit
ref: HEAD
resolved-ref: "652c49e02701bb6bb80953a6fdf650a5c8f002f9"
resolved-ref: "0b7b7e4d88a0bc574550a929835e0400c7c2d135"
url: "https://github.com/media-kit/media-kit"
source: git
version: "1.1.11"
Expand Down Expand Up @@ -953,7 +953,7 @@ packages:
description:
path: "libs/universal/media_kit_libs_video"
ref: HEAD
resolved-ref: "652c49e02701bb6bb80953a6fdf650a5c8f002f9"
resolved-ref: "0b7b7e4d88a0bc574550a929835e0400c7c2d135"
url: "https://github.com/media-kit/media-kit"
source: git
version: "1.0.5"
Expand All @@ -970,7 +970,7 @@ packages:
description:
path: media_kit_video
ref: HEAD
resolved-ref: "652c49e02701bb6bb80953a6fdf650a5c8f002f9"
resolved-ref: "0b7b7e4d88a0bc574550a929835e0400c7c2d135"
url: "https://github.com/media-kit/media-kit"
source: git
version: "1.2.5"
Expand Down Expand Up @@ -1251,10 +1251,10 @@ packages:
dependency: transitive
description:
name: pubspec_parse
sha256: c799b721d79eb6ee6fa56f00c04b472dcd44a30d258fac2174a6ec57302678f8
sha256: "81876843eb50dc2e1e5b151792c9a985c5ed2536914115ed04e9c8528f6647b0"
url: "https://pub.dev"
source: hosted
version: "1.3.0"
version: "1.4.0"
radio_browser_api:
dependency: "direct main"
description:
Expand Down Expand Up @@ -1760,18 +1760,18 @@ packages:
dependency: transitive
description:
name: wakelock_plus
sha256: bf4ee6f17a2fa373ed3753ad0e602b7603f8c75af006d5b9bdade263928c0484
sha256: "36c88af0b930121941345306d259ec4cc4ecca3b151c02e3a9e71aede83c615e"
url: "https://pub.dev"
source: hosted
version: "1.2.8"
version: "1.2.10"
wakelock_plus_platform_interface:
dependency: transitive
description:
name: wakelock_plus_platform_interface
sha256: "422d1cdbb448079a8a62a5a770b69baa489f8f7ca21aef47800c726d404f9d16"
sha256: "70e780bc99796e1db82fe764b1e7dcb89a86f1e5b3afb1db354de50f2e41eb7a"
url: "https://pub.dev"
source: hosted
version: "1.2.1"
version: "1.2.2"
watch_it:
dependency: "direct main"
description:
Expand Down Expand Up @@ -1856,10 +1856,10 @@ packages:
dependency: transitive
description:
name: yaml
sha256: "75769501ea3489fca56601ff33454fe45507ea3bfb014161abc3b43ae25989d5"
sha256: b9da305ac7c39faa3f030eccd175340f968459dae4af175130b3fc47e40d76ce
url: "https://pub.dev"
source: hosted
version: "3.1.2"
version: "3.1.3"
yaru:
dependency: "direct main"
description:
Expand Down

0 comments on commit cc6d113

Please sign in to comment.