fix: overflow in left pane of YaruMasterDetailPage (#787)

Fixes #785
ubuntu · Oct 19, 2023 · 9da3275 · 9da3275
1 parent 4e1cb14
commit 9da3275
Showing 1 changed file with 19 additions and 33 deletions.
diff --git a/lib/src/widgets/master_detail/yaru_master_list_view.dart b/lib/src/widgets/master_detail/yaru_master_list_view.dart
@@ -25,45 +25,31 @@ class YaruMasterListView extends StatefulWidget {
 }
 
 class _YaruMasterListViewState extends State<YaruMasterListView> {
-  final _controller = ScrollController();
-
-  @override
-  void dispose() {
-    _controller.dispose();
-    super.dispose();
-  }
-
   @override
   Widget build(BuildContext context) {
     final theme = YaruMasterDetailTheme.of(context);
-    return CustomScrollView(
-      controller: _controller,
-      slivers: [
-        SliverFillRemaining(
-          hasScrollBody: false,
-          child: Padding(
-            padding: theme.listPadding ?? EdgeInsets.zero,
-            child: Column(
-              children: List.generate(
-                widget.length,
-                (index) => YaruMasterTileScope(
-                  index: index,
-                  selected: index == widget.selectedIndex,
-                  onTap: () => widget.onTap(index),
-                  child: Builder(
-                    builder: (context) => widget.builder(
-                      context,
-                      index,
-                      index == widget.selectedIndex,
-                      widget.availableWidth,
-                    ),
-                  ),
+    return SingleChildScrollView(
+      child: Padding(
+        padding: theme.listPadding ?? EdgeInsets.zero,
+        child: Column(
+          children: List.generate(
+            widget.length,
+            (index) => YaruMasterTileScope(
+              index: index,
+              selected: index == widget.selectedIndex,
+              onTap: () => widget.onTap(index),
+              child: Builder(
+                builder: (context) => widget.builder(
+                  context,
+                  index,
+                  index == widget.selectedIndex,
+                  widget.availableWidth,
                 ),
-              ).withSpacing(theme.tileSpacing ?? 0),
+              ),
             ),
-          ),
+          ).withSpacing(theme.tileSpacing ?? 0),
         ),
-      ],
+      ),
     );
   }
 }