Add MEGAN2 BVOC emission process #111
Conversation
…TChem into feature/catchem_begins
tests/CATChem_config.yml
Outdated
| CO2_Inhib_Opt: true | ||
| CO2_conc_ppm: 390.0 |
There was a problem hiding this comment.
I think thus far we've been trying to keep keys all lowercase?
| !! \brief Contains MEGAN2.1 biogenic VOC emission Scheme based on HEMCO and Sam Silva's canopy edits | ||
| !! | ||
| !! Reference: | ||
| !! (1) Guenther et al, (GMD 2012) and associated MEGANv2.1 source code | ||
| !! https://doi.org/10.5194/gmd-5-1471-2012 | ||
| !! (2) Sam Silva's simplified canopy edits (GMD 2020) | ||
| !! https://doi.org/10.5194/gmd-13-2569-2020 |
There was a problem hiding this comment.
Does this incorporate any of Guenther's standalone MEGAN2.1 code mentioned here? Or is it more based on HEMCO's MEGAN2.1 implementation (in which case HEMCO references and links to GitHub or Zenodo could be added)? And to what extent does Silva's surrogate MEGAN3 come in here?
There was a problem hiding this comment.
It is more based on HEMCO and I did not refer to the standalone codes directly. THe HEMCO GitHub link is added now. Silva's edits are all included.
@zmoon Do you mean the warning below? I am not sure how it happens. Could you help me get rid of it? CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.10 will be removed from a future version of CMake. Update the VERSION argument value or use a ... suffix to tell CMake that the project does not need compatibility with older versions. |
Not that one, we can address that later, it's not related to your PR. I was talking about the warnings from the compiler: For example with gfortran-11 |
Oh ok. It seems to have some unused variables. I can clean them. But I guess we should keep the unused 'chemstate' and 'diagstate' for future use? |
If it's something you are reasonably sure may be used in the future, you can comment the declaration out instead of fully removing it (but still remove it from arguments if necessary to resolve the warning). And if you have "equality comparison for real" warning, you can use the |
zmoon
force-pushed
the
feature/catchem_begins
branch
from
53ad0f7 to
12d57c6
Compare
zmoon
force-pushed
the
feature/catchem_begins
branch
from
12d57c6 to
1bda156
Compare
@bbakernoaa The historical accumulation function is added with the new commit and saved to DiagState. I think it is better to be saved to restart files if we have that functionality created in the future. The time step is needed to add the historical effect. I am using the MetState TSTEP for now and not sure if a TSTEP is also necessary for EmisState. Another thing I noticed is the temperature historical effect is deactivated by Silva but the historical PAR is still used. |
|
@lwcugb I think it will but remember that CATChem is a column model and that the interface will pass that to the host model to be written out. It is also something that could be read in through the host model as well. TSTEP would be the correct variable. We could add an option flag to turn the effects on or off. Do you think that would be beneficial? |
Silva's paper suggests that the emissions are only slightly lower. Maybe his other edits make up for the historical temperature or the impact itself is small in the default algorithm (historical PAR may be more important?). So I guess it may not benefit a lot if we keep Silva's method. |
This pull request adds the MEGAN2.1 BVOC emission scheme based on its implementation in HEMCO.