Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize structure of ex-script for forecast task #121

Merged
merged 18 commits into from
Jul 1, 2024

Conversation

chan-hoo
Copy link
Collaborator

Description

  • Re-organize the structure of the ex-scripts for the forecast task to remove the direct use of the scripts of the ufs-weather-model.
  • Clean up some unnecessary lines.
  • Change the paths to the fix files in the input data directory.

Anticipated changes to regression tests:

  • Is baseline change expected ?

Subcomponents involved:

  • apply_incr.fd (NOAA-PSL/land-apply_jedi_incr)
  • ufsLand.fd (NOAA-EPIC/ufs-land-driver-emc-dev)
  • ufs_model.fd (ufs-community/ufs-weather-model)
  • vector2tile_converter.fd (NOAA-PSL/land-vector2tile)
  • none

Linked PR's and Issues:

Resolve Issue #120

Testing (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Derecho
  • CI
    • Completed
  • PW-Clouds
    • AWS
    • AZURE
    • GCP

@chan-hoo chan-hoo linked an issue Jun 27, 2024 that may be closed by this pull request
@chan-hoo
Copy link
Collaborator Author

On Hera:

    Start 1: test_vector2tile
1/7 Test #1: test_vector2tile .................   Passed    2.18 sec
    Start 2: test_create_ens
2/7 Test #2: test_create_ens ..................   Passed    2.81 sec
    Start 3: test_letkfoi_snowda
3/7 Test #3: test_letkfoi_snowda ..............   Passed    5.80 sec
    Start 4: test_apply_jediincr
4/7 Test #4: test_apply_jediincr ..............   Passed    2.23 sec
    Start 5: test_tile2vector
5/7 Test #5: test_tile2vector .................   Passed    2.93 sec
    Start 6: test_land_driver
6/7 Test #6: test_land_driver .................   Passed    9.08 sec
    Start 7: test_ufs_datm_land
7/7 Test #7: test_ufs_datm_land ...............   Passed   53.40 sec

100% tests passed, 0 tests failed out of 7

Total Test time (real) =  78.47 sec

@chan-hoo chan-hoo requested a review from jkbk2004 June 27, 2024 23:15
@chan-hoo
Copy link
Collaborator Author

On Orion:

    Start 1: test_vector2tile
1/7 Test #1: test_vector2tile .................   Passed    3.67 sec
    Start 2: test_create_ens
2/7 Test #2: test_create_ens ..................   Passed    3.57 sec
    Start 3: test_letkfoi_snowda
3/7 Test #3: test_letkfoi_snowda ..............   Passed   48.77 sec
    Start 4: test_apply_jediincr
4/7 Test #4: test_apply_jediincr ..............   Passed    3.63 sec
    Start 5: test_tile2vector
5/7 Test #5: test_tile2vector .................   Passed    4.17 sec
    Start 6: test_land_driver
6/7 Test #6: test_land_driver .................   Passed   17.36 sec
    Start 7: test_ufs_datm_land
7/7 Test #7: test_ufs_datm_land ...............   Passed  487.22 sec

100% tests passed, 0 tests failed out of 7

Total Test time (real) = 568.45 sec

Copy link
Collaborator

@jkbk2004 jkbk2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@chan-hoo chan-hoo merged commit aa4e002 into ufs-community:develop Jul 1, 2024
2 checks passed
@chan-hoo chan-hoo deleted the feature/forecast branch July 1, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ex-script for forecast task needs to be updated and cleaned-up
2 participants