feat: file downloads #332
Draft
feat: file downloads #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakebyrnes
force-pushed
the
downloads
branch
2 times, most recently
from
ebe746a to
2a2bb6c
Compare
blakebyrnes
force-pushed
the
downloads
branch
3 times, most recently
from
d40049c to
cc1a8ca
Compare
blakebyrnes
force-pushed
the
downloads
branch
2 times, most recently
from
f61b417 to
8323b47
Compare
|
Will this get implemented some day? |
Secret agent has mostly been retired and replaced with Hero and Unblocked. The individuals interested in this feature went away, so it never got the interest/work to be completed. There's a branch in unblocked for much of this work, but it hasn't been looked at in a while. One issue I never resolved is that I think ultimately, downloads should feel like regular resources, which requires a few changes like streaming downloads. Are you at all interested in trying to take on completing the feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a wip.
You can subscribe to "download" on a per-tab basis
tab.on('download', download: Download => ....). Download in client has a "waitForFinished" that you can use to wait until the download is completed.Currently, this is implemented by adding a hook into CorePlugins to a new Browser Context (ie, Incognito window).
The default plugin is currently registering the userDataDirectory/downloads as the downloads directory.
TODO:
@calebjclark Any other thoughts?