Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add FaultHandlerOverride tlv #38

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: add FaultHandlerOverride tlv #38

wants to merge 2 commits into from

Conversation

Qlas
Copy link
Collaborator

@Qlas Qlas commented Dec 23, 2024

#37

@Qlas Qlas self-assigned this Dec 23, 2024
@Qlas Qlas added the enhancement New feature or request label Dec 23, 2024
uncommon-nickname
uncommon-nickname approved these changes Dec 24, 2024
View reviewed changes
Copy link
Owner

@uncommon-nickname uncommon-nickname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/cfdp_core/pdu_tlv.cpp
{
const auto memory_size = memory.size();

if (memory_size < sizeof(uint8_t) + sizeof(uint8_t) + sizeof(uint8_t))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (memory_size < sizeof(uint8_t) + sizeof(uint8_t) + sizeof(uint8_t))
if (memory_size < 3 * sizeof(uint8_t))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uncommon-nickname uncommon-nickname uncommon-nickname approved these changes

Assignees

@Qlas Qlas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qlas @uncommon-nickname