Add script selection Import/Export feature #453
Conversation
- Improve validation for configuration import - Refactor SaveSelectionButton.vue implementation - Add floppy-disk-gear icon for SaveSelectionButton
undergroundwires
force-pushed
the
master
branch
2 times, most recently
from
080047d to
2f8aaf4
Compare
undergroundwires
force-pushed
the
master
branch
2 times, most recently
from
4dd8e11 to
64feb66
Compare
undergroundwires
force-pushed
the
master
branch
3 times, most recently
from
25d0d37 to
e6c52db
Compare
|
Hi @e-salad, I'm sorry for being too late at reviewing this. It's a very good contribution with a clean fix, and I'm really happy to see a good dev looking at it. This is the first time this project has gotten improvement at this depth. And I'm also surprised how cleanly you integrated it, using existing patterns/extending perfectly. Except some minor styling issues (npm run lint:eslint would fix those), it looks all good. The only issue is that it will be very painful to handle these files, so based on discussions at #59, I started working on #262. Unfortunately, it took ridiculous long amount of time to get it done due to bugs/other improvements I'm fixing at the side. This is my highest priority now for next feature release. And ID support will change some of the APIs on application layer. Would you be able to update this PR after that is done? Then instead of persisting the whole state, you'd need to persist the IDs only. And we can iterate with small features/commits on this to have proper backwards compatibility (what happens if something with a specific ID disappears etc.). |
|
Hi @undergroundwires, thank you for the kind words and feedback! I initially created this PR because I saw the presets ("Standard" and "Strict") as config files, so I thought we could support custom presets in a similar way. However, I closed it as I felt it might be too large of a change to introduce right away. (Apologies for missing previous discussions on this, i searched but couldn’t find them.) Please let me know how the final ID implementation turns out; I’d be happy to update this PR. If a specific ID is missing, one idea is to have a minimal, machine-readable changelog or just a simple mapping system. This could notify users if a script is removed or migrated to a new ID in rare cases like when a script is merged with another. Lastly, I implemented file input and input error handling directly within the import functionality. Would you prefer I move this into the existing workflows instead? Also, I couldn’t find a suitable icon for the desktop version, any suggestions? Looking forward to your updates! |
.