-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge fix for node stall ready search #38
Conversation
Looking at it again, it is now clear to me why this worked before the fix. The point of searching the With the old code where the search function for the So the fix only prevents the same node from being added to the stall affected nodes queue multiple times, nothing else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Minor suggestion for a comment.
Huh? Not sure why it says I dismissed the review. Let me see if I can revert that. Edit: Can't see where I can revert it. Makes no sense, not sure how this happened. GitHub is acting weird wrt. merge requests recently, sometimes it links completely unrelated issues automatically. |
Closes #28
Draft because tests still have to be run on how this affects overall operation. More info available in issue #28