Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group test results by definition #5144

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

sellout
Copy link
Contributor

@sellout sellout commented Jun 27, 2024

Overview

Avoids duplication in the output.

Follow-up to #5140.

Interesting/controversial decisions

With this new display, I’m wondering if it makes sense to not split the failures from the successes, so all the terns for a definition are together rather than having the definition duplicated in each list.

Test coverage

This is reflected in a number of transcripts.

@sellout sellout requested review from aryairani and ceedubs June 27, 2024 05:18
@sellout
Copy link
Contributor Author

sellout commented Jun 27, 2024

So, what do you think about moving to

  Cached test results (`help testcache` to learn more)
  
    1. fix5080.tests  ◉ got the right answer
                      ✗ [1, 2, 3]
   
   🚫 1 test(s) failing, ✅ 1 test(s) passing

instead of

  Cached test results (`help testcache` to learn more)
  
    1. fix5080.tests  ◉ got the right answer

    2. fix5080.tests  ✗ [1, 2, 3]
   
   🚫 1 test(s) failing, ✅ 1 test(s) passing

@sellout sellout force-pushed the group-test-results branch from 3e379c3 to 1a753ff Compare June 27, 2024 05:40
@ceedubs
Copy link
Contributor

ceedubs commented Jun 27, 2024

Nice!

@sellout I agree that for the small example, not printing the successes and failures separately looks better. But I do think that there is some benefit in putting all of the failures at the top or bottom so it's easy to find them if you have a bunch of tests run. No super strong opinions, though.

@sellout
Copy link
Contributor Author

sellout commented Jun 27, 2024

I agree that for the small example, not printing the successes and failures separately looks better. But I do think that there is some benefit in putting all of the failures at the top or bottom so it's easy to find them if you have a bunch of tests run.

Yeah, it can be nice to have the failures all together at the end. The output is also colorized, though, so it does make scanning a long list for failures pretty easy.

Regardless, it can stay the way it is for now, and it’s easy enough to change later if we want.

@ceedubs
Copy link
Contributor

ceedubs commented Jun 27, 2024

Just gave this a try and it's working great!

@aryairani aryairani merged commit f824743 into unisonweb:trunk Jun 27, 2024
20 checks passed
@sellout sellout deleted the group-test-results branch August 15, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants