Silence some Stack complaints #5231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a specific version of Stack, we don’t want Stack complaining to contributors that it doesn’t happen to be the latest.
We intentionally disable Stack’s Nix integration when it’s run from a Nix shell. We don’t want Stack complaining that we should enable it since it found `nix` on the path.
aryairani
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
By default, Stack will complain if you’re not using Nix integration when
nixis on thePATHand it will complain when you’re not using the latest version of Stack.We have reasons for not doing either of these things, and so we tell Stack to stop complaining.
Interesting/controversial decisions
Ideally, we could tell Stack to not complain about Nix only when we’re running from the Nix shell, but Stack doesn’t accept
--no-notify-if-nix-on-pathas a CLI flag, so we silence it more broadly.Test coverage
CI ensures that Stack runs as intended, but not whether these particular warnings are printed out or not. It’s simply a contributor convenience, and “it works for me.”