Update scheme-libs Readme.md & add .gitignore #5238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryairani
reviewed
Jul 19, 2024
Comment on lines
+1
to
+6
| compiled/ | ||
| boot-generated.ss | ||
| builtin-generated.ss | ||
| compound-wrappers.ss | ||
| data-info.ss | ||
| simple-wrappers.ss |
There was a problem hiding this comment.
I think this is okay.
@dolio is this okay?
There was a problem hiding this comment.
Yeah, pretty sure it's fine to ignore these. The .ss files are auto-generated from unison, and compiled/ is racket's build directory.
aryairani
approved these changes
Jul 19, 2024
|
Ok let's try! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update the Readme with a few things:
config.rktdis neededunison-runtimebut also how it is used byucmto compile to native codedevelopment.markdownabout how to build the native runtimeAlso a couple of misc updates:
development.markdown:integration-teststocli-integration-tests.gitignoreinscheme-libsto ignore generated filesgen-racket-libs.output.mdInteresting/controversial decisions
There's a few slightly unrelated changes that could be split into separate PRs but I'm also thinking the changes aren't that big so might as well keep them together. Let me know your thoughts!
Test coverage
n/a only documentation changes and local testing
Loose ends
Not sure? Maybe we can consider moving some of the information from the readme to the transcript?
(cc @dolio)