Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat all Haskell code #5239

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Reformat all Haskell code #5239

merged 3 commits into from
Jul 19, 2024

Conversation

sellout
Copy link
Contributor

@sellout sellout commented Jul 19, 2024

With #5142, Ormolu was upgraded from 0.5.2.0 to 0.7.2.0. This formats the codebase to avoid spurious formatting comingled in other commits.

Almost all of the changes are simply wrapping single constraints in parens, like

-hashBranch :: forall m. Monad m => Branch m -> m BranchHash
+hashBranch :: forall m. (Monad m) => Branch m -> m BranchHash

There is also some reordering of language pragmas and imports, indentation correction, and switching some Haddock from -- ^ to -- | .

Finally, there is now a .ormolu file, which gives Ormolu hints for operator precedence, and fixes some incorrect indentation in multi-line operator sequences.

sellout added 3 commits July 18, 2024 17:48
With unisonweb#5142, Ormolu was upgraded from 0.5.2.0 to 0.7.2.0. This formats
the codebase to avoid spurious formatting comingled in other commits.

Almost all of the changes are simply wrapping single constraints in parens, like
```diff
-hashBranch :: forall m. Monad m => Branch m -> m BranchHash
+hashBranch :: forall m. (Monad m) => Branch m -> m BranchHash
```

There is also some reordering of language pragmas and imports,
indentation correction (some of which gets precedence wrong), and switching
some Haddock from `-- ^` to `-- |` .
Changing `(A x) => (B y) => x -> y` to `(A x, B y) => x -> y`.
This adds a .ormolu file to tell Ormolu what some operator precedences
are, to improve indentation of multi-line operator sequences.
@aryairani aryairani merged commit 01b475c into unisonweb:trunk Jul 19, 2024
20 checks passed
@sellout sellout deleted the reformatting branch July 29, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants