Fix non-deterministic sorting of rows in transcripts #5275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fixes #5271
Results for the global reflog seem to be non-deterministic in transcripts :'(
It seems unlikely, but the only reason I could think of for this to happen with the current ORDER BY is if two rows are inserted with an identical timestamp; maybe
getCurrentTimereturns the same time if called within a ms or something.It's extremely unlikely this would ever occur outside of a transcript environment, but either way, just adding the ROWID as an additional sorting column guarantees they'll sort in insert order.
If we see this again we should assume there's some concurrency within the transcript runner (I did a quick scan and couldn't see any, even though we do use TVars for some reason) and look at sorting that out instead 👀
Implementation notes
Sort by RowID in addition to time.
Test coverage
Unfortunately I can't force flakiness, so we'll just have to see if it comes back.