merge API tweaks #5277
Merged
merge API tweaks #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellwrosen
commented
Aug 13, 2024
| @@ -1024,7 +1024,7 @@ Bob, meanwhile, first deletes the term, then sort of deletes the type and re-add | |||
| ``` ucm | |||
| project/bob> view Foo.Bar | |||
|
|
|||
| type Foo.Bar = Hello Nat Nat | Baz Nat | |||
There was a problem hiding this comment.
These are expected because we're reusing an existing unique type GUID, which affects constructor ordering.
aryairani
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR contains a small number of tweaks to the merge API from the last round of review:
UniqueNameto the parser.TypeLookup.Other misc cleanup: deleted a couple unused record fields.