Fix dev-ui-install.sh #5291
Merged
Fix dev-ui-install.sh #5291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into this when i tried running it in a non-POSIX shell. Nothing happened. Bash, when asked to run a script without a shebang will interpret it itself, while other shells behave differently (and I think this even depends on the OS – BSD (like macOS) & Linux handle `execvp` differently). This adds a shebang and some “strict” settings.
ceedubs
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I ran into this when i tried running it in a non-POSIX shell. Nothing happened. Bash, when asked to run a script without a shebang will interpret it itself, while other shells behave differently (and I think this even depends on the OS – BSD (like macOS) & Linux handle
execvpdifferently).This adds a shebang and some “strict” settings.
Test coverage
I only tested this by hand.