Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tcn loss only compute on output chunk #2006

Closed
wants to merge 6 commits into from
Closed

make tcn loss only compute on output chunk #2006

wants to merge 6 commits into from

Conversation

dennisbader
Copy link
Collaborator

Fixes #1965.

  • TCNModel computed the training loss also on the input chunk (past/history). changed so that is only computed on the output chunk (future/horizon)
  • removed now obsolete first_prediction_index and its occurences from torch models

@dennisbader dennisbader mentioned this pull request Sep 21, 2023
Closed
madtoinou
madtoinou reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @dennisbader,

The changes slightly increased the error in the tests, we should either update the hyper-parameters or the error threshold.

@dennisbader
Copy link
Collaborator Author

Closing as #1965 was answered from @pennfranc.

@dennisbader dennisbader deleted the fix/tcn_loss_input branch March 27, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madtoinou madtoinou madtoinou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question, possible BUG] Output of _TCNModule is a function of input_chunk_length, not output_chunk_length
2 participants
@dennisbader @madtoinou