Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/summary_plot() returns the shap values #2048

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

madtoinou
Copy link
Collaborator

Fixes #1353.

Summary

Simply appending the shap.Explanations used as input for the plot in a list then returned by the method. The shap values are stored in .values of each explanation.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
darts/explainability/shap_explainer.py 91.32% <100.00%> (+3.63%) ⬆️

... and 6 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @madtoinou 🚀
Had a minor suggestion

darts/explainability/shap_explainer.py Show resolved Hide resolved
Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks 🚀 💯

@dennisbader dennisbader merged commit 3fb1080 into master Nov 3, 2023
9 checks passed
@dennisbader dennisbader deleted the feat/return_shap_values branch November 3, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

Getting shap_explain.summary_plot() in a python list rarther than an image
3 participants