Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/d-attach defines function da but calls function dattach #111

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

kelbyers
Copy link

@kelbyers kelbyers commented Nov 1, 2024

Description

The script bin/d-attach defines a function named da, but calls function dattach, which is not defined. Running the script results in an error message:

❯ d-attach                                                      
/Users/jxb2016/.zgenom/sources/unixorn/fzf-zsh-plugin/___/bin/d-attach: line 36: dattach: command not found

This update changes the script so that it calls da.

Checklist

  • All new and existing tests pass.
  • Rather than adding functions to fzf-zsh-plugin.zsh, I have created standalone scripts in bin so they can be used by non-ZSH users too.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an ok exception)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have confirmed that the link(s) in my PR are valid.
  • I have read the CONTRIBUTING document.

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch! I appreciate you kicking the fix upstream.

@unixorn unixorn merged commit 06e2946 into unixorn:main Nov 1, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants