-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for sprites on serve #143
Conversation
Also creates a simple test for charites serve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keichan34
Thank you! I find this feature very useful for map styling.
Sorry for the detail, but even though I have an icons
directory, when I run charites serve style.yml
, the icons do not show up on the map.
If user has an icons
directory, I think charites should show local icons without explicitly specifying --sprite-input
.
I agree. But, I don't think it's in the scope of this PR. I think that |
@keichan34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #137, closes #62
When writing sprite support, I saw that there were no tests for the charites serve command, so I added some simple tests. While there were initially tests in #80, they were removed before merging because of some timeout issue. I think I've resolved those issues in this PR.
Description
Adds sprite support to the
serve
command. Uses the same--sprite-input
command line option asbuild
.Type of Pull Request
Verify the followings
main
branchnpm run build
npm run lint
charites help
globally