Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Mblv11 #92

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Use Mblv11 #92

merged 9 commits into from
Oct 30, 2024

Conversation

vtnate
Copy link
Collaborator

@vtnate vtnate commented Oct 8, 2024

  • Declare buildings library version 11.0.0 in the test package
  • Bump modelica-builder version to 0.6.0 because of that
  • bump dependencies with poetry update

@vtnate vtnate added the enhancement New feature or request label Oct 8, 2024
@vtnate vtnate self-assigned this Oct 8, 2024
@coveralls
Copy link

coveralls commented Oct 22, 2024 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 11597166690

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 93.488%
Files with Coverage Reduction New Missed Lines %
modelica_builder/modelica_project.py 1 87.25%
Totals Coverage Status
Change from base Build 11596760961: 0.0%
Covered Lines: 1895
Relevant Lines: 2027
💛 - Coveralls

@vtnate vtnate marked this pull request as ready for review October 24, 2024 19:52
@vtnate vtnate requested a review from nllong October 24, 2024 19:57
nllong
nllong approved these changes Oct 30, 2024
View reviewed changes
pyproject.toml
@@ -1,6 +1,6 @@
[tool.poetry]
name = "modelica-builder"
version = "0.5.2-rc2"
version = "0.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

tests/data/packages/teaser_single/package.mo
@@ -2,5 +2,5 @@ package teaser_single
extends Modelica.Icons.Package;

annotation (uses(
Modelica(version="4.0.0"), Buildings(version="10.0.0")), version="1");
Modelica(version="4.0.0"), Buildings(version="11.0.0")), version="1");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should figure out how to make this a variable. We don't need to do it now, but this should be set from somewhere else Modelica builder shouldn't care about the version of MBL/Buildings.

@vtnate vtnate merged commit c68b2e1 into develop Oct 30, 2024
2 checks passed
@vtnate vtnate deleted the mblv11 branch October 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nllong nllong nllong approved these changes

Assignees

@vtnate vtnate

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtnate @coveralls @nllong