Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image_math tool #686

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

kostrykin
Copy link
Contributor

Add the image_math tool from BMCV/galaxy-image-analysis#107

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the imgteam tools we do the update of the lock files automatically. https://github.com/usegalaxy-eu/usegalaxy-eu-tools/blob/master/Makefile#L40C1-L40C45

So no need to modify this file for trusted tools.

@bgruening bgruening merged commit 9988bc6 into usegalaxy-eu:master Mar 9, 2024
1 check passed
@kostrykin
Copy link
Contributor Author

For the imgteam tools we do the update of the lock files automatically. https://github.com/usegalaxy-eu/usegalaxy-eu-tools/blob/master/Makefile#L40C1-L40C45

So no need to modify this file for trusted tools.

Ah okay, this means I still need to add the entries for new tools to the .lock files, but not their revisions, right?

@kostrykin kostrykin deleted the add-image-math branch March 9, 2024 22:20
@bgruening
Copy link
Member

No, don't touch the lock file, its not needed for your tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants