Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow functions to work within a containerized environment by switching sass-embedded to sass #23

Closed

Conversation

smustgrave
Copy link

#20

@smustgrave
Copy link
Author

Unfortunately still not working

@smustgrave smustgrave changed the title Make functions async Allow functions to work within a containerized environment May 9, 2022
@smustgrave smustgrave changed the title Allow functions to work within a containerized environment Allow functions to work within a containerized environment by switching sass-embedded to sass May 12, 2022
@mejiaj
Copy link
Contributor

mejiaj commented May 23, 2022

@smustgrave so removing sass embedded didn't fix the issue?

@thisisdano should we close this issue or re-frame it so there's an option to switch from sass to sass-embedded?

@smustgrave
Copy link
Author

@mejiaj removing sass-embedded did fix the issue for us. Haven't had a change to break apart the node module to figure out why that one is failing.

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smustgrave thanks for the contribution. Ideally users should be able to choose between embedded vs sass. We don't want to lose the performance benefits of embedded to users who can use it.

This would be a boolean that would, ideally, conditionally load sass with and without sass embedded.

@smustgrave
Copy link
Author

Thanks for all the time and effort looking into this!

@mejiaj
Copy link
Contributor

mejiaj commented Oct 8, 2024

Closing in favor of solution for #32.

@mejiaj mejiaj closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants