-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI #3
Conversation
This is the same CI as uutils-term-grid. If this works I want to release this crate. |
.github/workflows/ci.yml
Outdated
uses: codecov/codecov-action@v4 | ||
# if: steps.vars.outputs.HAS_CODECOV_TOKEN | ||
with: | ||
# token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codevov
requires a token
# token: ${{ secrets.CODECOV_TOKEN }} | |
token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah so I need to enable the if
line above that as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is necessary because the token should always be there as it has to be added to Github's settings.
@cakebaker ah, so now we need the codecov token. How do we do that? |
@tertsdiepraam we have to get it from codecov.io and then add it as a secret on github, see https://github.com/codecov/codecov-action/?tab=readme-ov-file#usage |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Alright, I think I fixed it :) |
No description provided.