Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #3

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Add CI #3

merged 1 commit into from
Feb 10, 2024

Conversation

tertsdiepraam
Copy link
Member

No description provided.

@tertsdiepraam
Copy link
Member Author

tertsdiepraam commented Feb 9, 2024

This is the same CI as uutils-term-grid. If this works I want to release this crate.

uses: codecov/codecov-action@v4
# if: steps.vars.outputs.HAS_CODECOV_TOKEN
with:
# token: ${{ secrets.CODECOV_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codevov requires a token

Suggested change
# token: ${{ secrets.CODECOV_TOKEN }}
token: ${{ secrets.CODECOV_TOKEN }}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so I need to enable the if line above that as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is necessary because the token should always be there as it has to be added to Github's settings.

@tertsdiepraam
Copy link
Member Author

@cakebaker ah, so now we need the codecov token. How do we do that?

@cakebaker
Copy link
Contributor

cakebaker commented Feb 9, 2024

@tertsdiepraam we have to get it from codecov.io and then add it as a secret on github, see https://github.com/codecov/codecov-action/?tab=readme-ov-file#usage

Copy link

codecov bot commented Feb 10, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@tertsdiepraam
Copy link
Member Author

Alright, I think I fixed it :)

@sylvestre sylvestre merged commit 2c9b469 into main Feb 10, 2024
9 checks passed
@sylvestre sylvestre deleted the ci branch February 10, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants