Minor github pages deployment fixes #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomey
approved these changes
May 7, 2024
scottyhq
commented
May 7, 2024
| @@ -59,6 +59,6 @@ runs: | |||
| if: ${{ always() && inputs.jb-save == 'true'}} | |||
| uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: build-${{ inputs.os }} | |||
| name: build-${{ runner.os }} | |||
There was a problem hiding this comment.
this is automatically set on all runners, so don't need to pass it as an input https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables
|
@jomey looks like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #163, which was hard to test, since we needed to actually run a deployment by merging to main
I also fixed one path here, and it seems to work well 3854ac5
Composite workflow does not seem to be picking up step outputs, so removing this, and using whatever is set by default (not sure if it will pick up custom cname, but it's really just a convenience anyways to have the URL easily accessible from the actions log)
Environment URL '' is not a valid http(s) URL, so it will not be shown as a link in the workflow graph.Also add runner os to actions artifact name (in the case of a matrix job rendering the website on both linux and macos there will not be a name conflict)