-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SL Micro 6.1 hosts #1771
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,14 @@ variable "slemicro_minion_configuration" { | |
} | ||
} | ||
|
||
variable "slmicro_minion_configuration" { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need a minion for slmicro ? Can't we reuse the slemicro minion. Just a question. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can reuse it indeed. |
||
description = "use module.<SL_MICRO_MINION_NAME>.configuration, see main.tf.libvirt-testsuite.example" | ||
default = { | ||
ids = [] | ||
hostnames = [] | ||
} | ||
} | ||
|
||
variable "buildhost_configuration" { | ||
description = "use module.<BUILDHOST_NAME>.configuration, see main.tf.libvirt-testsuite.example" | ||
default = { | ||
|
@@ -352,13 +360,27 @@ variable "slmicro60_minion_configuration" { | |
} | ||
} | ||
|
||
variable "slmicro61_minion_configuration" { | ||
description = "use module.<SLMICRO61_MINION>.configuration, see main.tf.libvirt-testsuite.example" | ||
default = { | ||
hostnames = [] | ||
} | ||
} | ||
|
||
variable "slmicro60_sshminion_configuration" { | ||
description = "use module.<SLMICRO60_SSHMINION>.configuration, see main.tf.libvirt-testsuite.example" | ||
default = { | ||
hostnames = [] | ||
} | ||
} | ||
|
||
variable "slmicro61_sshminion_configuration" { | ||
description = "use module.<SLMICRO61_SSHMINION>.configuration, see main.tf.libvirt-testsuite.example" | ||
default = { | ||
hostnames = [] | ||
} | ||
} | ||
|
||
variable "centos7_minion_configuration" { | ||
description = "use module.<CENTOS7_MINION>.configuration, see main.tf.libvirt-testsuite.example" | ||
default = { | ||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -332,6 +332,28 @@ module "slemicro_minion" { | |||||||||||||||||||||||||||||||||
provider_settings = lookup(local.provider_settings_by_host, "slemicro_minion", {}) | ||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
module "slmicro_minion" { | ||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need a minion for slmicro ? Can't we reuse the slemicro minion. Just a question. |
||||||||||||||||||||||||||||||||||
source = "../minion" | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
quantity = contains(local.hosts, "slmicro_minion") ? 1 : 0 | ||||||||||||||||||||||||||||||||||
base_configuration = module.base.configuration | ||||||||||||||||||||||||||||||||||
image = lookup(local.images, "slmicro_minion", "slmicro61o") | ||||||||||||||||||||||||||||||||||
name = lookup(local.names, "slmicro_minion", "slmicro-minion") | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
server_configuration = local.minimal_configuration | ||||||||||||||||||||||||||||||||||
sles_registration_code = lookup(local.sles_registration_code, "slmicro_minion", null) | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
use_os_released_updates = true | ||||||||||||||||||||||||||||||||||
ssh_key_path = "./salt/controller/id_rsa.pub" | ||||||||||||||||||||||||||||||||||
install_salt_bundle = lookup(local.install_salt_bundle, "slmicro_minion", true) | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
additional_repos = lookup(local.additional_repos, "slmicro_minion", {}) | ||||||||||||||||||||||||||||||||||
additional_repos_only = lookup(local.additional_repos_only, "slmicro_minion", false) | ||||||||||||||||||||||||||||||||||
additional_packages = lookup(local.additional_packages, "slmicro_minion", ["avahi", "avahi-lang", "libavahi-common3", "libavahi-core7"]) | ||||||||||||||||||||||||||||||||||
additional_grains = lookup(local.additional_grains, "slmicro_minion", {}) | ||||||||||||||||||||||||||||||||||
provider_settings = lookup(local.provider_settings_by_host, "slmicro_minion", {}) | ||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
module "rhlike_minion" { | ||||||||||||||||||||||||||||||||||
source = "../minion" | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
|
@@ -471,6 +493,7 @@ module "controller" { | |||||||||||||||||||||||||||||||||
minion_configuration = contains(local.hosts, "suse_minion") ? module.suse_minion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] } | ||||||||||||||||||||||||||||||||||
sshminion_configuration = contains(local.hosts, "suse_sshminion") ? module.suse_sshminion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] } | ||||||||||||||||||||||||||||||||||
slemicro_minion_configuration = contains(local.hosts, "slemicro_minion") ? module.slemicro_minion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] } | ||||||||||||||||||||||||||||||||||
slmicro_minion_configuration = contains(local.hosts, "slmicro_minion") ? module.slmicro_minion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] } | ||||||||||||||||||||||||||||||||||
# TODO: rename redhat_configuration and debian_configuration to rhlike_configuration and deblike_configuration once the renaming is done: https://github.com/SUSE/spacewalk/issues/25062 | ||||||||||||||||||||||||||||||||||
redhat_configuration = contains(local.hosts, "rhlike_minion") ? module.rhlike_minion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] } | ||||||||||||||||||||||||||||||||||
debian_configuration = contains(local.hosts, "deblike_minion") ? module.deblike_minion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] } | ||||||||||||||||||||||||||||||||||
|
@@ -505,6 +528,7 @@ output "configuration" { | |||||||||||||||||||||||||||||||||
proxy = var.container_proxy ? module.proxy_containerized[0].configuration : module.proxy[0].configuration | ||||||||||||||||||||||||||||||||||
suse_client = module.suse_client.configuration | ||||||||||||||||||||||||||||||||||
slemicro_minion = module.slemicro_minion.configuration | ||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I checked the controller, we are parsing those slemicro and slmicro minion variables but we are actually doing nothing with it. sumaform/modules/controller/variables.tf Lines 57 to 63 in aed8598
If you search in controller/main.tf, we don't use this variable. We don't declare it in bashrc controller. sumaform/salt/controller/bashrc Lines 5 to 13 in f76bf6c
|
||||||||||||||||||||||||||||||||||
slmicro_minion = module.slmicro_minion.configuration | ||||||||||||||||||||||||||||||||||
suse_minion = module.suse_minion.configuration | ||||||||||||||||||||||||||||||||||
suse_sshminion = module.suse_sshminion.configuration | ||||||||||||||||||||||||||||||||||
rhlike_minion = module.rhlike_minion.configuration | ||||||||||||||||||||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ uyuni_key_for_fake_packages: | |
- name: transactional-update -c run rpm --import http://{{ grains.get("mirror") | default("minima-mirror-ci-bv.mgr.prv.suse.net", true) }}/uyuni.key | ||
{% endif %} | ||
|
||
{% if not (grains['osfullname'] in ['SL-Micro'] and grains['osrelease'] in ['6.0']) and not (grains['osfullname'] in ['openSUSE Leap Micro'] and grains['osrelease'] in ['5.5']) %} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we support both 6.0 and 6.1 ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right. But in fact here, what we do is to NOT support this salt state if we are on a transactional system. |
||
{% if not (grains['osfullname'] in ['SL-Micro'] and grains['osrelease'] in ['6.1']) and not (grains['osfullname'] in ['openSUSE Leap Micro'] and grains['osrelease'] in ['5.5']) %} | ||
test_repo_rpm_pool: | ||
pkgrepo.managed: | ||
- baseurl: http://{{ grains.get("mirror") | default("downloadcontent.opensuse.org", true) }}/repositories/systemsmanagement:/Uyuni:/Test-Packages:/Pool/rpm/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slemicro61o is not supported by user_data.yaml but combustion. Those changes need to be impacted in combustion (if needed).
sumaform/backend_modules/libvirt/host/main.tf
Line 7 in aadfe2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check if what is already in combustion is not enough.