Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache: cache map & meta data #12

Conversation

naranjamecanica
Copy link
Contributor

I was unable to push to the other PR so hereby my proposed changes to complete the caching functionality! 👍🏻

@naranjamecanica naranjamecanica changed the title Update: create new cache map when options change Cache: create new cache map when options change & store meta data about compression savings when cached Nov 21, 2023
@naranjamecanica naranjamecanica changed the title Cache: create new cache map when options change & store meta data about compression savings when cached Cache: cache map & meta data Nov 21, 2023
@vHeemstra
Copy link
Owner

My apologies, I had not noticed this PR 🤦‍♂️
So I continued implementing the things we mentioned without realizing you were too (you said, but I forgot).

I think my version is very similar to yours. Would you have a look at the latest state of the feature branch and let me know if I missed anything? (Or made mistakes 😄)

I made an open pending PR for merging the feature branch into main. This PR should reflect the latest stage.

Again, sorry for missing the work you put in, I still really appreciate it!

@naranjamecanica
Copy link
Contributor Author

No problem! Looking forward to save al lot of time (and ⚡).. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants