refactor!: replace _shouldSetInvalid with manualValidation property

[vursen]

Description

Enables manual validation mode for web components instead of overriding the protected _shouldSetInvalid method. This is a breaking change, as it stops web components from dispatching the validated event.

Depends on

• refactor: deprecate ClientValidatedEvent and HasClientValidation #6795

Type of change

• Refactor

[sonarqubecloud]

Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[vursen]

This refactor can break applications that listen for ClientValidatedEvent – it's no longer fired with enabled manual validation. We should probably deprecate this event first. HasClientValidation will also become obsolete.

[knoobie]

Suggestion because ClientValidatedEvent is kinda recent and probably not much used (hopefully):

• Add a "compatibility mode" as feature flag which uses the old code - which a user has to active.. so 24.6 uses the new method and people that need the old way can still return back by adding the flag (which would be removed in 25.?)

e.g.:

// Pseudo Code
if(attachEvent.getUI().getFeatureFlags(LEGACY_CLIENT_VALIDATION_EVENT_ENABLED, false)) 
  ClientValidationUtil.preventWebComponentFromModifyingInvalidState(this);
else 
  getElement().setProperty("manualValidation", true);

[vursen]

@knoobie Thanks for the suggestion. I'm afraid this refactoring isn't worth a feature flag since it's just an internal improvement to use public APIs instead of protected ones. I think we could just hold off this change until a later time.