Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked layouttester tests to be more informative. (#11800) #11813

Merged
merged 5 commits into from
Mar 23, 2020

Conversation

Ansku
Copy link
Member

@Ansku Ansku commented Nov 14, 2019

This change is Reviewable

@Ansku Ansku force-pushed the update20191111testsV8 branch from 1b1b0de to 29379e6 Compare November 14, 2019 15:43
@TatuLund
Copy link
Contributor

Does this supercede #11688 ?

@Ansku
Copy link
Member Author

Ansku commented Nov 15, 2019

Does this supercede #11688 ?

What do you mean? It's a different set of tests.

@Ansku Ansku force-pushed the update20191111testsV8 branch 2 times, most recently from 7d682aa to fc8a387 Compare November 19, 2019 10:14
@Ansku Ansku force-pushed the update20191111testsV8 branch from fc8a387 to faf0ee7 Compare November 19, 2019 14:06
Copy link
Contributor

@TatuLund TatuLund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 132 of 132 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@TatuLund TatuLund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants