fix: set aria-checked properly when checked is null (#165)

Co-authored-by: Phan Hong Duc <[email protected]>
vaadin · Mar 19, 2020 · ee07e8c · ee07e8c
1 parent 35977f5
commit ee07e8c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/vaadin-checkbox.html b/src/vaadin-checkbox.html
@@ -221,7 +221,7 @@
           if (this.indeterminate) {
             this.setAttribute('aria-checked', 'mixed');
           } else {
-            this.setAttribute('aria-checked', checked);
+            this.setAttribute('aria-checked', Boolean(checked));
           }
         }
 

diff --git a/test/accessibility.html b/test/accessibility.html
@@ -70,6 +70,10 @@
           expect(vaadinCheckbox.getAttribute('aria-checked')).to.be.eql('mixed');
         });
 
+        it('should set aria-checked to "false" when checked is set to null', () => {
+          vaadinCheckbox.checked = null;
+          expect(vaadinCheckbox.getAttribute('aria-checked')).to.eql('false');
+        });
       });
 
     });