Skip to content

Commit

Permalink
fix: avoid cp39-musllinux_aarch64 timeout (#2434)
Browse files Browse the repository at this point in the history
* Skip musllinux_aarch64 wheels

* Build using backward-compatible numpy API (#5)

* Build using backward-compatible numpy API

* Add deprecated oldest-supported-numpy

* Bring back cp39+ musllinux_aarch64 wheels

* Note that numpy~=2.0 fails currently

* Add explicit upper bound on python 3.12

* Quick fix for fingerprints

* Add more fingerprints

* Pin dask instead of adding fingerprints
  • Loading branch information
ddelange authored Sep 18, 2024
1 parent 4864874 commit 3c27267
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/wheel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,13 @@ jobs:

- id: set-matrix
env:
# skipping pypy for now, cp38-win was segfaulting on CI, numpy has no wheels for cp38-musllinux_aarch64 -> build from source -> CI timeouts
CIBW_SKIP: pp* cp38-win* cp38-musllinux_aarch64
# skipping pypy for now
# cp38-win was segfaulting on CI -> skipping for now
# oldest-supported-numpy has no wheels for cp38-musllinux_aarch64 -> build numpy from source on QEMU -> CI timeouts -> skipping for now
CIBW_SKIP: >
pp*
cp38-win*
cp38-musllinux_aarch64
run: |
MATRIX_INCLUDE=$(
{
Expand Down
3 changes: 2 additions & 1 deletion packages/vaex-core/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
[build-system]
# Minimum requirements for the build system to execute.
requires = [
"oldest-supported-numpy",
"oldest-supported-numpy; python_version=='3.8'", # deprecated ref https://github.com/scipy/oldest-supported-numpy
"numpy~=1.25; python_version>'3.8'", # numpy~=2.0 fails, backward compatible build-system as of v1.25 ref https://numpy.org/doc/2.1/dev/depending_on_numpy.html#build-time-dependency
"scikit-build",
"cmake",
"ninja"
Expand Down
4 changes: 2 additions & 2 deletions packages/vaex-core/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"numpy~=1.17",
"aplus",
"tabulate>=0.8.3",
"dask!=2022.4.0",
"dask!=2022.4.0,<2024.9", # fingerprinting in no longer deterministic as of 2024.9.0
"future>=0.15.2",
"pyyaml",
"six",
Expand Down Expand Up @@ -263,7 +263,7 @@ def __str__(self):
if not use_skbuild
else [],
zip_safe=False,
python_requires=">=3.8",
python_requires=">=3.8,<3.13", # 3.13 needs numpy 2.1 support ref https://github.com/vaexio/vaex/pull/2434
classifiers=[
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
Expand Down

0 comments on commit 3c27267

Please sign in to comment.