Skip to content

Commit

Permalink
chore: make sure we catch gil release errors from pybind11
Browse files Browse the repository at this point in the history
  • Loading branch information
maartenbreddels committed Oct 7, 2024
1 parent 2d2addd commit 9882acd
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/vaex-core/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,13 @@ def __str__(self):
]
extra_compile_args.append("-g")
extra_compile_args += extra_dev_options
# this makes sure we catch error in using pybind11, see https://github.com/vaexio/vaex/issues/2439
extra_compile_args += ["-UNDEBUG"]
if sys.platform == "darwin":
extra_compile_args.append("-mmacosx-version-min=10.9")



# on windows (Conda-forge builds), the dirname is an absolute path
extension_vaexfast = Extension(
"vaex.vaexfast",
Expand Down

0 comments on commit 9882acd

Please sign in to comment.