Skip to content

Commit

Permalink
Remove git submodule update from DEVELOPER.md (#2894)
Browse files Browse the repository at this point in the history
Signed-off-by: Shachar Langbeheim <[email protected]>
  • Loading branch information
nihohit authored Jan 2, 2025
1 parent c0a903c commit a4d7fe1
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 19 deletions.
14 changes: 4 additions & 10 deletions csharp/DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,27 +85,21 @@ Before starting this step, make sure you've installed all software requirments.
cd valkey-glide
```

2. Initialize git submodule

```bash
git submodule update --init --recursive
```

3. Build the C# wrapper
2. Build the C# wrapper

```bash
dotnet build
```

4. Run tests
3. Run tests

Run test suite from `csharp` directory:

```bash
dotnet test
```

5. Run benchmark
4. Run benchmark

1. Ensure that you have installed `redis-server` and `redis-cli` on your host. You can find the Redis installation guide at the following link: [Redis Installation Guide](https://redis.io/docs/install/install-redis/install-redis-on-linux/).

Expand All @@ -125,7 +119,7 @@ dotnet test

Run benchmarking script with `-h` flag to get list and help about all command line parameters.

6. Lint the code
5. Lint the code

Before making a contribution ensure that all new user API and non-obvious places in code is well documented and run a code linter.

Expand Down
14 changes: 5 additions & 9 deletions go/DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,32 +105,28 @@ Before starting this step, make sure you've installed all software requirements.
git clone --branch ${VERSION} https://github.com/valkey-io/valkey-glide.git
cd valkey-glide
```
2. Initialize git submodules:
```bash
git submodule update --init --recursive
```
3. Install build dependencies:
2. Install build dependencies:
```bash
cd go
make install-build-tools
```
4. If on CentOS or Ubuntu, add the glide-rs library to LD_LIBRARY_PATH:
3. If on CentOS or Ubuntu, add the glide-rs library to LD_LIBRARY_PATH:
```bash
# Replace "<path to valkey-glide>" with the path to the valkey-glide root, eg "$HOME/Projects/valkey-glide"
GLIDE_ROOT_FOLDER_PATH=<path to valkey-glide>
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$GLIDE_ROOT_FOLDER_PATH/go/target/release/deps/
```
5. Build the Go wrapper:
4. Build the Go wrapper:
```bash
make build
```
6. Run tests:
5. Run tests:
1. Ensure that you have installed valkey-server and valkey-cli on your host. You can find the Valkey installation guide at the following link: [Valkey Installation Guide](https://github.com/valkey-io/valkey).
2. Execute the following command from the go folder:
```bash
go test -race ./...
```
7. Install Go development tools with:
6. Install Go development tools with:
```bash
# For go1.22:
make install-dev-tools
Expand Down

0 comments on commit a4d7fe1

Please sign in to comment.