Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Fix return types, part 2: float64 instead of Result[float64] and bool #2941

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Go: Fix return types, part 2: float64 instead of Result[float64] and bool #2941

merged 5 commits into from
Jan 14, 2025

Conversation

Yury-Fridlyand
Copy link
Collaborator

Return float64 instead of Result[float64] where possible.
Few commands still return nullable float64, but no commands return nullable bool

@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Jan 11, 2025
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner January 11, 2025 22:26
@Yury-Fridlyand
typo fix
4426fd3 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
fix
8aa2d4d 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jan 14, 2025
Merged
6 tasks
jbrinkman
jbrinkman approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval with type corrections in method names

go/api/base_client.go Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand merged commit de6ed02 into valkey-io:main Jan 14, 2025
17 of 18 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the go/fix-return-types-2 branch January 14, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@jbrinkman jbrinkman jbrinkman approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @jbrinkman @prateek-kumar-improving