Moved documentation comments to base_client file and made changes to GlideClient for pkgsite to work #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Liang <[email protected]>
* GO: add xpending command Signed-off-by: jbrinkman <[email protected]> Signed-off-by: Edward Liang <[email protected]>
* GO Implement Dump and ObjectEncoding command Signed-off-by: EdricCua <[email protected]> Signed-off-by: Edward Liang <[email protected]>
* Implement Echo Command Signed-off-by: EdricCua <[email protected]> Signed-off-by: Edward Liang <[email protected]>
* Go: `XREADGROUP`. Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Edward Liang <[email protected]>
* Shadow protobuf Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Edward Liang <[email protected]>
…key-io#2967) Signed-off-by: TJ Zhang <[email protected]> Co-authored-by: TJ Zhang <[email protected]> Signed-off-by: Edward Liang <[email protected]>
* Go: `XAUTOCLAIM`. Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Edward Liang <[email protected]>
…-io#2956) * Go: update return types & response handlers for scan commands Signed-off-by: TJ Zhang <[email protected]> Signed-off-by: Edward Liang <[email protected]>
…-io#2958) * Implement Object Freq, Idle and RefCount Signed-off-by: EdricCua <[email protected]> Signed-off-by: Edward Liang <[email protected]>
…2888) * Sort,Sort_RO,Sort Store commands Signed-off-by: Niharika Bhavaraju <[email protected]> Signed-off-by: Edward Liang <[email protected]>
* Go: `XGROUP CREATE`. Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Edward Liang <[email protected]>
…y-io#2975) * go xGroupCreateConsumer and XGroupDelConsumer Signed-off-by: jbrinkman <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Edward Liang <[email protected]>
* Fix return types. Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Edward Liang <[email protected]>
Fix return types Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Yury-Fridlyand
approved these changes
Jan 22, 2025
jbrinkman
approved these changes
Jan 22, 2025
go/api/glide_client.go
Outdated
| // GlideClient is a client used for connection in Standalone mode. | ||
| type GlideClient interface { | ||
| // IGlideClient is a client used for connection in Standalone mode. | ||
| type IGlideClient interface { |
There was a problem hiding this comment.
Rename symbol IGlideClient to GlideClientCommands to better align the interface name to what it actually represents - an aggregation of all of the command interfaces.
go/api/glide_cluster_client.go
Outdated
| @@ -7,30 +7,57 @@ package api | |||
| import "C" | |||
|
|
|||
| // GlideClusterClient interface compliance check. | |||
| var _ GlideClusterClient = (*glideClusterClient)(nil) | |||
| var _ IGlideClusterClient = (*GlideClusterClient)(nil) | |||
There was a problem hiding this comment.
Rename symbol IGlideClusterClient to GlideClusterClientCommands to better align the interface name to what it actually represents - an aggregation of all of the command interfaces.
| // If key exists, returns the value of key as a Result[string]. Otherwise, return [api.CreateNilStringResult()]. | ||
| // | ||
| // For example: | ||
| // 1. key: value |
There was a problem hiding this comment.
Indentation should be consistent for the entire file for documentation.
There was a problem hiding this comment.
On GitHub you can set for the appearance of tabs to be 4 spaces instead (for some reason the default is 8 ) and that "fixes" the appearance issue. All good
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL):
Checklist
Before submitting the PR make sure the following are checked: