ORT- Add resolutions for hybrid-node-tests and bump versions #2987
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BoazBD <[email protected]>
BoazBD
force-pushed
the
boaz/bump-ort-version
branch
from
5e7a18b to
8311661
Compare
Signed-off-by: BoazBD <[email protected]>
avifenesh
reviewed
Jan 21, 2025
| submodules: recursive | ||
|
|
||
| - name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@1.78 | ||
| uses: dtolnay/rust-toolchain@1.82 |
There was a problem hiding this comment.
It encounters error: [DefaultDispatcher-worker-2] ERROR org.ossreviewtoolkit.analyzer.PackageManager - Cargo failed to resolve dependencies for path 'rust-client/Cargo.toml': IllegalArgumentException: Unsupported lockfile version 4.
avifenesh
reviewed
Jan 21, 2025
| @@ -74,11 +74,11 @@ jobs: | |||
| with: | |||
| repository: "oss-review-toolkit/ort" | |||
| path: "./ort" | |||
| ref: "26.0.0" | |||
| ref: "44.0.0" | |||
There was a problem hiding this comment.
And why here specify the version?
I guess we didn't before, and added the old one because of the failure.
There was a problem hiding this comment.
When not specifing the version, the default one is 0.1.0-001.s
There was a problem hiding this comment.
You mean very old ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): [REPLACE ME]
Checklist
Before submitting the PR make sure the following are checked: