Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Implement Server Management Command DBSize #2991

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Go: Implement Server Management Command DBSize #2991

wants to merge 18 commits into from
+65 −0

Conversation

EdricCua
Copy link
Collaborator

@EdricCua EdricCua commented Jan 22, 2025 •
edited by janhavigupta007
Loading

Issue link

This Pull Request is linked to issue (URL): #2876

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@EdricCua EdricCua requested a review from a team as a code owner January 22, 2025 06:45
@EdricCua EdricCua mentioned this pull request Jan 22, 2025
Open
7 tasks
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Jan 22, 2025
EdricCua and others added 10 commits January 23, 2025 03:21
@EdricCua
Fix test
392d540 
Signed-off-by: EdricCua <[email protected]>
@Yury-Fridlyand @EdricCua
Go: Fix return types, parn 5 (valkey-io#2964)
aa2bf43 
Fix return types

Signed-off-by: Yury-Fridlyand <[email protected]>
@prateek-kumar-improving @EdricCua
Go xack command new (valkey-io#2982)
ca3d070 
* Go: Add XAck command

Signed-off-by: Prateek Kumar <[email protected]>
@Yury-Fridlyand @EdricCua
Go: XGROUP SETID. (valkey-io#2976)
4bbcf57 
* Go: `XGROUP SETID`.

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand @EdricCua
Go: XGROUP DESTROY. (valkey-io#2974)
710b414 
* Go: `XGROUP CREATE`.

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand @EdricCua
Go: HRANDFIELD. (valkey-io#2977)
607193e 
* Go: `HRANDFIELD`.

Signed-off-by: Yury-Fridlyand <[email protected]>
@niharikabhavaraju @EdricCua
Go: Implement GetBit, SetBit, BitCount and Wait commands (valkey-io#2918
8613dcf 
)

* Added bitmap commands,wait commands

Signed-off-by: Niharika Bhavaraju <[email protected]>
@Angraybill @EdricCua
Implemented IFEQ set command in python with tests (valkey-io#2962)
2da1fc7 
* Define new function, change paramter type to Union, add conditionals for IFEQ

Signed-off-by: Angraybill <[email protected]>

* Tests for IFEQ, positive and negative cases

Signed-off-by: Angraybill <[email protected]>

* Update Changelog

Signed-off-by: Angraybill <[email protected]>

* Import OnlyIfEqual in init file

Signed-off-by: Angraybill <[email protected]>

---------

Signed-off-by: Angraybill <[email protected]>
@tjzhang-BQ @EdricCua
Go: Add command XClaim (valkey-io#2984)
acf052a 
* Go: Add command XClaim

Signed-off-by: TJ Zhang <[email protected]>
@EdricCua
Merge branch 'main' into Go-Implement-DBSize-Command
626911d
janhavigupta007
janhavigupta007 reviewed Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@janhavigupta007 janhavigupta007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the tests.

go/integTest/standalone_commands_test.go Outdated Show resolved Hide resolved
@EdricCua
Fix test
d6f4620 
Signed-off-by: EdricCua <[email protected]>
EdricCua and others added 3 commits January 23, 2025 06:06
@EdricCua
Fix test
0bf0172 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix test
921fcc0 
Signed-off-by: EdricCua <[email protected]>
@prateek-kumar-improving @EdricCua
Go xack command new (valkey-io#2982)
03a2b93 
* Go: Add XAck command

Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: EdricCua <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@janhavigupta007 janhavigupta007 janhavigupta007 approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@EdricCua @janhavigupta007 @Yury-Fridlyand @prateek-kumar-improving @niharikabhavaraju @Angraybill @tjzhang-BQ