Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Madelyn Olson <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
  • Loading branch information
zuiderkwast and madolson authored Jan 23, 2025
1 parent 12067d4 commit 1ec49fa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions tests/unit/dump.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,8 @@ start_server {tags {"dump"}} {
# str len RDB 222 CRC64 checksum
# | | | |
set bar_dump "\x00\x03bar\xde\x00\x0fYUza\xd3\xec\xe0"
catch {r restore foo 0 $bar_dump replace} e
set e
} {ERR DUMP payload version or checksum are wrong}
assert_error {ERR DUMP payload version or checksum are wrong} {r restore foo 0 $bar_dump replace}
}

test {RESTORE key with future RDB version, relaxed version check} {
# str len RDB 222 CRC64 checksum
Expand Down
2 changes: 1 addition & 1 deletion valkey.conf
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ rdbchecksum yes

# Valkey can try to load an RDB dump produced by a future version of Valkey.
# This can only work on a best-effort basis, because future RDB versions may
# contain information that's not know to the current version. If no new features
# contain information that's not known to the current version. If no new features
# are used, it may be possible to import the data produced by a later version,
# but loading is aborted if unknown information is encountered. Possible values
# are 'strict' and 'relaxed'. This also applies to replication and the RESTORE
Expand Down

0 comments on commit 1ec49fa

Please sign in to comment.