Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor syncWithPrimary and replicaTryPartialResynchronization #1476

Open
wants to merge 16 commits into
base: unstable
Choose a base branch
from

Merge branch 'valkey-io:unstable' into unstable

0a8c42e
Select commit
Loading
Failed to load commit list.
Open

Refactor syncWithPrimary and replicaTryPartialResynchronization #1476

Merge branch 'valkey-io:unstable' into unstable
0a8c42e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 22, 2025 in 1s

70.96% (+0.16%) compared to 7fc958d

View this Pull Request on Codecov

70.96% (+0.16%) compared to 7fc958d

Details

Codecov Report

Attention: Patch coverage is 73.60406% with 52 lines in your changes missing coverage. Please review.

Project coverage is 70.96%. Comparing base (7fc958d) to head (0a8c42e).

Files with missing lines Patch % Lines
src/replication.c 73.60% 52 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1476      +/-   ##
============================================
+ Coverage     70.80%   70.96%   +0.16%     
============================================
  Files           121      121              
  Lines         65132    65187      +55     
============================================
+ Hits          46118    46262     +144     
+ Misses        19014    18925      -89     
Files with missing lines Coverage Δ
src/replication.c 87.08% <73.60%> (-0.42%) ⬇️

... and 12 files with indirect coverage changes