-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add paused_actions for INFO Clients #1519
Conversation
Signed-off-by: zhaozhao.zz <[email protected]>
fc28ff0
to
bc2757d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1519 +/- ##
============================================
+ Coverage 70.83% 70.95% +0.11%
============================================
Files 120 120
Lines 64911 65060 +149
============================================
+ Hits 45982 46164 +182
+ Misses 18929 18896 -33
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good info field to add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix the format error and it's good for me.
I am confused why this pr is tagged as major-decision-pending? |
This field will be "none" most of the time, right? If we add many fields like this, is the size of the INFO reply a concern? I remember for the graceful shutdown feature, we added a field that is only present during shutdown:
In the same way, I wanted to add the availability_zone in HELLO reply only if it's non-empty, to avoid bloating the reply with a field that's always empty for many users. |
this make sense to me, i also mention this in #1131 (comment). I would also want a purpose field if we add the action. |
@valkey-io/core-team Although it is approved, status is still major-decision pending, can we just have a vote for it? |
Signed-off-by: zhaozhao.zz <[email protected]>
7afc8a6
to
31153d2
Compare
Signed-off-by: zhaozhao.zz <[email protected]>
The "stats" section is maybe wrong? Isn't it better to put it in another INFO section? |
@zuiderkwast which section you think is better? |
Signed-off-by: zhaozhao.zz <[email protected]>
Stats is counters of various information. |
Signed-off-by: zhaozhao.zz <[email protected]>
|
I was going to suggest client or server, since it's server side state. I don't feel strongly to change it, I also agreed I thought stats was the wrong place. |
In valkey-io#1519, we added paused_actions and paused_timeout_milliseconds, it would be helpful if we add the paused_purpose since users also want to know the purpose for the pause. Signed-off-by: Binbin <[email protected]>
Add `paused_actions` and `paused_timeout_milliseconds` for INFO Clients to inform users about if clients are paused. --------- Signed-off-by: zhaozhao.zz <[email protected]> Signed-off-by: proost <[email protected]>
Add
paused_actions
andpaused_timeout_milliseconds
for INFO Clients to inform users about if clients are paused.