Change the shared format for dual channel replication logs #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ran Shidlansik <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1586 +/- ##
============================================
- Coverage 70.94% 70.82% -0.12%
============================================
Files 121 121
Lines 65132 65132
============================================
- Hits 46207 46129 -78
- Misses 18925 19003 +78
|
naglera
approved these changes
Jan 19, 2025
enjoy-binbin
approved these changes
Jan 20, 2025
zuiderkwast
pushed a commit
to zuiderkwast/placeholderkv
that referenced
this pull request
Jan 21, 2025
…#1586) change the format of the dual channel replication logs so that it will not conflict with existing log formats like modules. Fixes: valkey-io#1509 Signed-off-by: Ran Shidlansik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the format of the dual channel replication logs so that it will not
conflict with existing log formats like modules.
Fixes: #1509