Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test Protocol desync regression test with TLS #1593

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix test Protocol desync regression test with TLS #1593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions tests/unit/protocol.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ start_server {tags {"protocol network"}} {
} else {
set s [socket [srv 0 host] [srv 0 port]]
}
fconfigure $s -blocking 0
puts -nonewline $s $seq
# PROTO_INLINE_MAX_SIZE is hardcoded in Valkey code to 64K. doing the same here
# since we would like to validate it is enforced.
Expand All @@ -94,12 +93,7 @@ start_server {tags {"protocol network"}} {
break
}
}

wait_for_condition 50 100 {
[string match {*Protocol error*} [gets $s]]
} else {
fail "expected connection to be closed on protocol error after sending $payload_size bytes"
}
assert_match {*Protocol error*} [gets $s]]
close $s
}
}
Expand Down
Loading