Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to disable pause after fork for dual channel test #1612

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Make sure to disable pause after fork for dual channel test #1612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/integration/dual-channel-replication.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,7 @@ start_server {tags {"dual-channel-replication external:skip"}} {
fail "Primary did not free repl buf block after sync failure"
}
wait_and_resume_process 0
$replica debug pause-after-fork 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to understand: this needs to be disabled before reading the log msgs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can go anywhere after the wait_and_continue, but before the end of the test.

Copy link
Contributor

@zuiderkwast zuiderkwast Jan 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the replica is getting stuck in sync loops, we should disable it ASAP, right? Not after the three stop_write_load in the end of the test case.

We can disable pause-after-fork here, but then I think we should also move the enabling of pause-after-fork inside the test case (the test { ... } block), rather than before the start of the test case. Symmetry like that makes it easier to follow the logic, and also to skip test cases using --only and similar options.

set res [wait_for_log_messages -1 {"*Unable to partial resync with replica * for lack of backlog*"} $loglines 20000 1]
set loglines [lindex $res 0]
}
Expand Down
Loading