Use default equality for asm_syntax structs #592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use C++20 default equality operator for the internal eBPF syntax. This is more robust to changes, and any instruction should be encoded in a way that supports this operator.
The only struct that uses a custom operator is
Call
; it contains type and name information that do not really belong there, and should be extracted in a future PR (which may help generalizing callx implementation from the basic support in #584).Some unmarshalling tests are affected:
is64
field; for now it is worked around in the test. (Branch cleanup-c++20 implements an alternative, encoding width for all unary operations).IMO this PR is better merged before #591.